Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue1212 durack1 spyder2.3.4 update #1213

Closed
wants to merge 6 commits into from
Closed

Issue1212 durack1 spyder2.3.4 update #1213

wants to merge 6 commits into from

Conversation

durack1
Copy link
Member

@durack1 durack1 commented Apr 13, 2015

No description provided.

@durack1 durack1 changed the title fix #1212 - Update spyder 2.3.2 to 2.3.4 fix #1212 - Update spyder 2.3.3 to 2.3.4 Apr 13, 2015
@durack1 durack1 changed the title fix #1212 - Update spyder 2.3.3 to 2.3.4 Issue1212 durack1 spyder2.3.4 update Apr 13, 2015
@durack1
Copy link
Member Author

durack1 commented Apr 15, 2015

@aashish24 this is a great candidate for testing out the travis build issue - the lean build never touches the spyder source, so there is absolutely no reason why this pull request should have reported an error.

@durack1
Copy link
Member Author

durack1 commented Apr 21, 2015

@aashish24 @jbeezley @doutriaux1 should I tweak and resubmit this PR for testing through the new build system? As noted above spyder is never even touched in the lean builds that were configured last time this PR was updated...

@aashish24
Copy link
Contributor

@durack1 don't worry about it. Can it wait until 2.2 happens?

@durack1
Copy link
Member Author

durack1 commented Apr 23, 2015

@aashish24 @doutriaux1 if it was possible it'd be great to get this patch update into 2.2.. But if you guys are trying to simplify things 2.3 would be ok I suppose..

@aashish24
Copy link
Contributor

@durack1 we have a strict deadline which is due in next few days. You wait is really appreciated. We will get it merged as soon as we tag 2.2

@durack1
Copy link
Member Author

durack1 commented May 6, 2015

@doutriaux1 @aashish24 I just had a go at rebasing this off UV-CDAT/uvcdat release branch, I'm doubtful this will build.. So please ignore this..

@durack1
Copy link
Member Author

durack1 commented May 6, 2015

@doutriaux1 @aashish24 ok wow, it did (not all that surprising as it's now basically just the release branch, with the spyder update which is never built)..

@doutriaux1 I'm not sure you folks feel comfortable about merging such changes for 2.2?

@doutriaux1
Copy link
Contributor

@durack1 I'll try a full build again once #1267 has been approved. If it works then I guess i'll merge it in.

@durack1
Copy link
Member Author

durack1 commented May 7, 2015

Ok great, I'll do the same rebasing for #1129, #1130 and #1131 and see how these also go..

@durack1
Copy link
Member Author

durack1 commented May 7, 2015

@doutriaux1 you might want to cherry pick the one file that's changed CMake/cdat_modules/spyder_pkg.cmake

@durack1
Copy link
Member Author

durack1 commented May 7, 2015

@doutriaux1 @aashish24 @jbeezley this PR should be deprecated by #1300 which seems to have triggered the buildbot testing

@durack1
Copy link
Member Author

durack1 commented May 11, 2015

@aashish24 @jbeezley @doutriaux1 it still seems those 3 errors, DVD3D image lines, DODS and netcdf version being picked up errors are still occurring: https://open.cdash.org/viewTest.php?onlyfailed&buildid=3808629

@durack1
Copy link
Member Author

durack1 commented May 11, 2015

@aashish24 @jbeezley it seems that netcdf version issue is only a problem on garant. The test-laptop only has the DVD3D image line and the DODS issue.. https://open.cdash.org/viewTest.php?onlyfailed&buildid=3808646

@jbeezley
Copy link
Contributor

I fixed that in #1298, which isn't in master. test-laptop is compiling libcf against a system installed lapack. garant doesn't have a system installed lapack, so it builds without regridding.

@durack1
Copy link
Member Author

durack1 commented May 11, 2015

@doutriaux1 @aashish24 should #1298 also be merged into master then?

@durack1 durack1 added this to the 2.3 milestone May 11, 2015
@aashish24
Copy link
Contributor

@durack1 looks like @jbeezley had it merged into another PR.

@durack1
Copy link
Member Author

durack1 commented May 19, 2015

@doutriaux1 closing this and will reissue a new PR rebased off current master

@durack1 durack1 closed this May 19, 2015
@durack1 durack1 deleted the issue1212_durack1_Spyder2.3.4Update branch May 19, 2015 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants