-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue1212 durack1 spyder2.3.4 update #1213
Conversation
@aashish24 this is a great candidate for testing out the travis build issue - the |
@aashish24 @jbeezley @doutriaux1 should I tweak and resubmit this PR for testing through the new build system? As noted above spyder is never even touched in the lean builds that were configured last time this PR was updated... |
@durack1 don't worry about it. Can it wait until 2.2 happens? |
@aashish24 @doutriaux1 if it was possible it'd be great to get this patch update into 2.2.. But if you guys are trying to simplify things 2.3 would be ok I suppose.. |
@durack1 we have a strict deadline which is due in next few days. You wait is really appreciated. We will get it merged as soon as we tag 2.2 |
Fix list method
…ck1/uvcdat into issue1212_durack1_Spyder2.3.4Update
@doutriaux1 @aashish24 I just had a go at rebasing this off UV-CDAT/uvcdat release branch, I'm doubtful this will build.. So please ignore this.. |
@doutriaux1 @aashish24 ok wow, it did (not all that surprising as it's now basically just the release branch, with the spyder update which is never built).. @doutriaux1 I'm not sure you folks feel comfortable about merging such changes for 2.2? |
@doutriaux1 you might want to cherry pick the one file that's changed CMake/cdat_modules/spyder_pkg.cmake |
@doutriaux1 @aashish24 @jbeezley this PR should be deprecated by #1300 which seems to have triggered the buildbot testing |
@aashish24 @jbeezley @doutriaux1 it still seems those 3 errors, DVD3D image lines, DODS and netcdf version being picked up errors are still occurring: https://open.cdash.org/viewTest.php?onlyfailed&buildid=3808629 |
@aashish24 @jbeezley it seems that netcdf version issue is only a problem on garant. The test-laptop only has the DVD3D image line and the DODS issue.. https://open.cdash.org/viewTest.php?onlyfailed&buildid=3808646 |
I fixed that in #1298, which isn't in master. |
@doutriaux1 @aashish24 should #1298 also be merged into master then? |
@doutriaux1 closing this and will reissue a new PR rebased off current master |
No description provided.